Update throwing off or me just wrong?

[willuwontu]

adds 1 to the threat range of light or one-handed swords they are wielding in (20 becomes 19-20, 19-20 becomes 18-20, etc.). This bonus is doubled with the Improved critical feat, keen, or the keen edge spell.

Phase: First  Priority: 10000

    ~ only perform the calculations for the first copy
      doneif (tagis[Helper.FirstCopy] = 0)

      ~ If we're not shown, just get out now
      doneif (tagis[Helper.ShowSpec] = 0)

foreach pick in hero from BaseWep where "(thingid.wSwordBast| thingid.wButtSwo| thingid.wDuelSwo| thingid.wFalcata| thingid.wGladius| thingid.wKatana| thingid.wKhopesh| thingid.wLongsword| thingid.wBroaNine| thingid.wRapier| thingid.wPFSawtoot| thingid.wScimitar| thingid.wScizore| thingid.wShortswd| thingid.wShotel| thingid.wSica| thingid.wSwordCane| thingid.wPFTempleS| thingid.wWakizashi | thingid.wUnarmed) & wCritMin.16"
        perform eachpick.delete[wCritMin.16]
        perform eachpick.assign[wCritMin.15]
nexteach

foreach pick in hero from BaseWep where "(thingid.wSwordBast| thingid.wButtSwo| thingid.wDuelSwo| thingid.wFalcata| thingid.wGladius| thingid.wKatana| thingid.wKhopesh| thingid.wLongsword| thingid.wBroaNine| thingid.wRapier| thingid.wPFSawtoot| thingid.wScimitar| thingid.wScizore| thingid.wShortswd| thingid.wShotel| thingid.wSica| thingid.wSwordCane| thingid.wPFTempleS| thingid.wWakizashi | thingid.wUnarmed) & wCritMin.17"
        perform eachpick.delete[wCritMin.17]
        perform eachpick.assign[wCritMin.16]
nexteach

foreach pick in hero from BaseWep where "(thingid.wSwordBast| thingid.wButtSwo| thingid.wDuelSwo| thingid.wFalcata| thingid.wGladius| thingid.wKatana| thingid.wKhopesh| thingid.wLongsword| thingid.wBroaNine| thingid.wRapier| thingid.wPFSawtoot| thingid.wScimitar| thingid.wScizore| thingid.wShortswd| thingid.wShotel| thingid.wSica| thingid.wSwordCane| thingid.wPFTempleS| thingid.wWakizashi | thingid.wUnarmed) & wCritMin.18"
        perform eachpick.delete[wCritMin.18]
        perform eachpick.assign[wCritMin.17]
nexteach

foreach pick in hero from BaseWep where "(thingid.wSwordBast| thingid.wButtSwo| thingid.wDuelSwo| thingid.wFalcata| thingid.wGladius| thingid.wKatana| thingid.wKhopesh| thingid.wLongsword| thingid.wBroaNine| thingid.wRapier| thingid.wPFSawtoot| thingid.wScimitar| thingid.wScizore| thingid.wShortswd| thingid.wShotel| thingid.wSica| thingid.wSwordCane| thingid.wPFTempleS| thingid.wWakizashi | thingid.wUnarmed) & wCritMin.19"
        perform eachpick.delete[wCritMin.19]
        perform eachpick.assign[wCritMin.18]
nexteach

foreach pick in hero from BaseWep where "(thingid.wSwordBast| thingid.wButtSwo| thingid.wDuelSwo| thingid.wFalcata| thingid.wGladius| thingid.wKatana| thingid.wKhopesh| thingid.wLongsword| thingid.wBroaNine| thingid.wRapier| thingid.wPFSawtoot| thingid.wScimitar| thingid.wScizore| thingid.wShortswd| thingid.wShotel| thingid.wSica| thingid.wSwordCane| thingid.wPFTempleS| thingid.wWakizashi | thingid.wUnarmed) & wCritMin.20"
        perform eachpick.delete[wCritMin.20]
        perform eachpick.assign[wCritMin.19]
nexteach

So prior to me updating today this script was working(at least yesterday it was), any Idea on what is going wrong with it now?

 

[AndrewD2]

While I'm not sure why your code isn't working, I did work up a cleaner version that might help.

var critrange as number

foreach pick in hero from BaseWep where "wClass.OneHanded | wClass.Light"
   critrange = eachpick.tagvalue[wCritMin.?]
   critrange -= 1
   perform eachpick.delete[wCritMin.?]
   perform eachpick.assignstr["wCritMin." & critrange]
nexteach

Not tested, but should work

 

[willuwontu]

thanks for the code cleanup help. I'm horrible at setting up var in this.

on the other had now my herolab is broken i think. Putting in that code brought up this error

Hero Lab was forced to stop compilation after the following errors were detected:

Syntax error in 'eval' script for Thing 'cBMDdlyBld' (Eval Script '#1') on line 10
  -> Reference to undeclared variable: 'foreach'

It still shows up when I switch back to the old code.....wtf

 

[AndrewD2]

well I just fixed the code in my last post, so give that a try again

 

[willuwontu]

well no more error, but it doesn't function for some reason hmmm....

 

[AndrewD2]

What is the code on? Feat? Class Ability? Race Ability?

 

[willuwontu]

Class special ability.

Semi found the issue

      ~ If we're not shown, just get out now
      doneif (tagis[Helper.ShowSpec] = 0)

I had that above the code initially but I guess the timing isn't right for it anymore. This creates other issues now (like this happening at level 1 when it's supposed start at level 9)

 

[AndrewD2]

Correct, before Post-Levels 1000 that stop won't work, do you need to run the code that early?

 

[AndrewD2]

try this

~we're earlier than the normal test for whether we've reached the correct level, so we'll recreate that test here
doneif (root.field[cTotalLev].value + field[xExtraLev].value + field[xEffectLev].value < tagvalue[ClSpecWhen.?])

 

[willuwontu]

Hmm i'll try it after post level 1000 again, I think I did that when I was making it but changed it for some reason.

 

[willuwontu]

Hmm that fixed it. Thank you for your help.... I can't figure out why I set it as first still hmm...

Seriously Though, thanks

 

[AndrewD2]

No prob, I was learning at one point too (and I still learn new stuff all the time)