flaw giving negatives to attack

[psych777]

so i seem to have this working, but wanted to verify a few things.

1. in the first column of the portfolio, titled 'Basics', it has your hero's BAB and Attack Bonus, etc.
What exactly is the Attack Bonus consist of? i created a new char who has a +1 BAB and gets a +1 for Str of 13. it shows there the hero has:
+1 BAB
+1 Attack Bonus
+2 (Melee)
+2 (Ranged)
if i change Str down to 11 (getting a mod of +0), the Attack Bonus doesn't change but the Melee drops to +1.
(i normally just look at my weapon for my attack bonus so never noticed how this column worked)

2. so my has this effect: "You suffer a -2 penalty on attack rolls made while not riding a mount."
should this -2 change the Attack Bonus, (Melee) and (Ranged) values in this column? i currently have the script running Post-levels/7490 and it is reducing all three (and the modifiers displayed on the weapons themselves)

3. not sure when the Attack 'Penalty' field is used (i couldn't find anything to populate it) so i couldn't test if there was say a "-1" in there already, would the below script 'add' the -2 to it to make a -3 or is my script worded wrong for that? wanted it to add a -2 to any current value to account for the flaw's affect.
if (hero.child[pstMounted].field[pIsOn].value = 0) then
hero.child[Attack].field[Penalty].value += -2
endif

seems to be working correctly, just wanted to make sure i was doing it right (its the first item i've created affecting the hero without having to ask for help BEFORE i got the desired outcome! baby steps hehe)

 

[Aaron]

1 - BAB is Base Attack Bonus
Attack is BAB + "Global" modifiers to attacks (for example if you got a +2 sacred bonus to attack)
Melee is the above line + Str modifier
Ranged is line 2 + Dex modifier.

2 - Yes, since it is a global penalty to all attacks, it would be reflected in line 2 through 4

3 - I believe your script will stack with any other penalties. From a style point though, I would subtract 2 rather than adding -2. Like so:

hero.child[Attack].field[Penalty].value -= 2

Congratulations on working this out yourself, man! Keep it up and you'll be a master in time!

 

[psych777]

thanks. i'd never used the "+=" before herolab and wasn't sure if "-=" worked in the same manner. definitely prefer that way as well and will change it.