Foreach Save proficiency code not working

[Fenris447]

I'm having trouble figuring out what is wrong with my code. This is supposed to add situational text on any saves the Hero is not proficient with, while the referenced ability is active.

It shows the situational text on all saveswhen activated, no matter what I do.

     ~ If we're disabled, do nothing & 
     doneif (tagis[Helper.Disable] <> 0 )
   
      doneif (hero.childfound[cWlk5CPacTal].field[abilActive].value = 0)    

     var sText as string
     sText = "+1d4"

     foreach pick in hero from BaseSave where "!Helper.ProfDouble & !Helper.Proficient"
   #situational[eachpick,sText,field[thingname].text]
         nexteach

The weird thing is, almost the exact same code works just fine for skills. Only the non-proficient skills get the situational when activated.

     ~ If we're disabled, do nothing & 
     doneif (tagis[Helper.Disable] <> 0 )

      doneif (field[abilActive].value = 0)    

     var sText as string
     sText = "+1d4"

     foreach pick in hero from BaseSkill where "!Helper.ProfDouble & !Helper.Proficient"

         #situational[eachpick,sText,field[thingname].text]
         nexteach

I don't think it's a timing issue, as I've tried a whole bunch of different ones. Interestingly enough, any timing before Final phase causes the situational to show up twice on each save.

 

[Fenris447]

I figured it out. Unlike skills, there's an extra save that is svAll. The code was applying to svAll, because normally characters aren't proficient with that. Which is why the situational showed up twice on some saves. It showed up twice on each save that the hero wasn't proficient in (once for STR, once for ALL), and once on the proficient saves (once for ALL).

So when I added "& !ProfSave.svAll" to the end of the tag expression, it worked perfectly.