Expr-reqs vs Pre-reqs

[psych777]

been workin on some of the blade skills for the soulknife and one of them is Improved Evasion. so i thought i'd sneak a look at the rogue version of IE to see what they did there.

with the Soulknife version i created, i used a Expr-reqs to put the level requirement in with the expression:
#levelcount[Soulknife] >= 10

but i noticed on the rogue version they used a Pre-reqs to put in the level requirement with this script:
var classcheck as string
var levels as number
classcheck = "Rogue"
call LevPreReqs
validif (levels >= 10)

anyone able to tell me if it would be better to change mine to imitate the rogue version? is the rogue version faster?

 

[AndrewD2]

The rogue version uses a procedure to check when other classes count as rogue levels, everything is hard coded into the procedure so if you used it nothing would be valid because the soulknife isn't in there, so your Expr-Req is correct.

 

[ShadowChemosh]

Please see the latest Data Authoring release notes for Ultimate Psionics HERE. You see I added a custom procedure that ALL new Custom Abilities are to use.

-Added new procedure "PUPreReqs" which should be used for all Custom Abilities level checking. See "Deadly Blow" for an example.

Please use PUPreReqs for all your new Custom Abilities:

var classcheck as string
var levels as number
classcheck = "Soulknife"
call PUPreReqs 
validif (levels >= 10)

[smartass]Its worth reading my notes. [/smartass]

The reason is the same as why LW did it. We will need to support strange Archetypes and PrC like the Soul Archer. In those cases the Soul Archer level STACKS with Soulknife levels. Meaning that your new Blade Skills need to take this into account. The new procedure I wrote will do this. Plus give us a single place to implement future changes and needs.

I like "simple" and I like code being in a single place not spread all over the place.

 

[ShadowChemosh]

The rogue version uses a procedure to check when other classes count as rogue levels, everything is hard coded into the procedure so if you used it nothing would be valid because the soulknife isn't in there, so your Expr-Req is correct.

Not 100% true. That procedure LW wrote will work with ANY class it just wont' do anything special like calc Soul Archer and Soulknife levels together. But it would return to you the Soulknife levels.

As long as the "classes.?" tag is really Soulknife. So keep in mind psych777 that other classes added later do NOT have nice names like "Soulknife". In example Soul Archer is "PUSoulArch" and its cHelpPUA for its helper thing.

This is needed to attempt to keep us TRUELY unique against all the other classes in HL.

 

[Aaron]

Also, just a reminder to folks in general, you can now copy procedures in the editor to see the code they contain. That'd be certainly be helpful if you want to know why to use a procedure vs. not.

 

[ShadowChemosh]

Also, just a reminder to folks in general, you can now copy procedures in the editor to see the code they contain. That'd be certainly be helpful if you want to know why to use a procedure vs. not.

Yep which IS a fantastic new feature. Its how I was able to figure out what this was doing and why. Plus mimic a custom version that is similar but for Psionic classes.

 

[psych777]

great info all, thanks.

i vaguely remember your post about that shadow...its just been too long since i read it and when i actually opened herolab again and didn't remember until you mentioned it again here )

 

[ShadowChemosh]

great info all, thanks.

i vaguely remember your post about that shadow...its just been too long since i read it and when i actually opened herolab again and didn't remember until you mentioned it again here )

No issues. I was just messing with you. I understand people have lives outside of HL.