[Bug Report] Composite Longbows usable with Simple Weapon Proficiency

[Portilis]

I'm sure there used to be an official bug report thread...

Anyway, it looks like Composite Longbow has managed to somehow make its way into classing as a simple weapon. I've only tested with a small range of classes, but it doesn't appear as proficient for wizards who have a specific list, but does appear so on classes with simple weapon proficiency.

 

[Asandir]

http://forums.wolflair.com/showthread.php?t=53560

 

[Mathias]

And I just tested on a blank character, adding only a level of Wizard and a composite longbow, and that character's not proficient, so include more information about the character, because there's something else going on.

 

[ShadowChemosh]

I just tested with a Sorcerer that does get Simple Weapon Proficiency and they are not proficient with Longbows. You sure your character's race is not a Elf that gets Longbow and Composite Longbow proficiency?

 

[Portilis]

Well... I span up a clean VM and used a spare license to go through and install everything one item at a time.

The result is, before I install the Pathfinder Pack (v1.6), all is good. Once installed, I get the bug (as seen on screenshot attached).

I've not added any of my own files to the build yet, so definitely not a conflict from there, the only stuff currently present is LWD based and the community pack.

Test character is a human sorcerer (arcane bloodline) with non-bow related feats and no special extras. All books and options are unticked in hero settings.

Bizarrely, whilst it isn't applying the non-prof penalty to the composite longbow (yet is for the longbow, as seen), the wNoProf field still has the penalty listed correctly, and the comp. longbow still shows up as a non-proficient weapon when purchasing.

 

[ShadowChemosh]

I just tested again and yeah when the Community Pack is present a Composite Longbow changes from a Martial to Simple weapon. But only after its added to a character. I can't currently figure out what is doing this. I just searched for all the obvious methods of changing a Pick tag and I find nothing. In addition this is happening when NO Sources are active.

@Mathias can you think of any non-obvious ways to have weapon get converted from wProfReq.Martial to wProfReq.Simple?

 

[Mathias]

Finally found it. The problem lies in an item called "Compound Bow", wMHCombow, in COM_PackModern - Path Heroes.user

Here's the code in Hero Lab - it's for weapons like the Aldori Dueling Sword:

      ~ Look through all the weapons we count as - if any of them are an easier
      ~ proficiency level, use that instead
      ~ NOTE - foreach thing in BaseWep is slow because of the number of things
      ~         we have, so we want to avoid doing this as much as possible. If
      ~         the weapon only has one IsWeapon tag, that's it's own tag, so
      ~         there's no need to look for any other weapons at all.
      if (tagcount[IsWeapon.?] > 1) then
        foreach thing in BaseWep where tagids[IsWeapon.?,"|"]
          if (eachthing.tagis[wProfReq.Martial] <> 0) then
            if (tagis[wProfReq.Exotic] <> 0) then
              perform tagreplace[wProfReq.?,wProfReq.Martial]
              endif
          elseif (eachthing.tagis[wProfReq.Simple] <> 0) then
            if (tagis[wProfReq.Exotic] + tagis[wProfReq.Martial] <> 0) then
              perform tagreplace[wProfReq.?,wProfReq.Simple]
              endif
            endif
          nexteach
        endif

So because the Compound Bow has IsWeapon.wCompLong, and is a simple weapon, composite longbows become a simple weapon. That weapon also has IsWeapon.wLongbow, but because the Longbow only has one IsWeapon tag of its own, it doesn't run this test.

 

[ShadowChemosh]

Finally found it. The problem lies in an item called "Compound Bow", wMHCombow, in COM_PackModern - Path Heroes.user

Nice find! Thats sort of crazy. I had looked at that weapon as it was one of the few places to have the wCompLong ID. But I was like how does a "IsWeapon" tag change the proficiency. Well now I know.

This will be fixed in the next update....