My tweaks to support Themes

[Daphne Pfister]

Originally Posted by MagicSN

Attached: Fey Beast Trainer Theme

Isn't it Fey Beast Tamer btw?

[MagicSN]

Originally Posted by Daphne Pfister

Isn't it Fey Beast Tamer btw?

Oh, just checked. You are right ;-) Fixed (file is still named FeyTrainer.user, though).

BTW: What about starting off a repository or such to contain all themes people put together?

MagicSN

[MagicSN]

Hi!

BTW, one thing I just remembered... on my Wizard's Apprentice Theme there is still the issue that Color Orb is supposed to use the "stat which is highest" as basis for hitting and for the damage bonus. Currently I just used "Int" as this is the highest ability for my wizard ;-)

Anyone who has a better solution to the problem, some script or such so that actually the highest ability is used? It is actually a problem which is not only for Color Orb, I think several themes have this issue with their powers.

MagicSN

[Daphne Pfister]

Originally Posted by MagicSN

BTW, one thing I just remembered... on my Wizard's Apprentice Theme there is still the issue that Color Orb is supposed to use the "stat which is highest" as basis for hitting and for the damage bonus. Currently I just used "Int" as this is the highest ability for my wizard ;-)

I thought about mentioning that. You can do it with a script, check some existing scripts for similar powers to see how it's done, or I'll try to dig up something after I finished bowling tonight.

[Daphne Pfister]

Okay this is dry coded ( and untested ) but should be close.

Add an eval script phase Traits, timing should be after Calc attrBonus
With this code:

var bonus as number
var attridstring as string

~ Use Int as default - this might not be necessary
bonus = #attrbonus[attrInt]
attridstring = "attrInt"

~ Find highest bonus
foreach pick in hero from Attribute
  if (eachpick.field[attrBonus].value > bonus) then
    bonus = eachpick.field[attrBonus].value
    attridstring = eachpick.field[name].idstring
  endif
nexteach

~ Use that as the damage and attack attributes
perform assignstr["DamageAttr." & attridstring]
perform assignstr["Attack." & attridstring]

Make sure that damage attribute and attack attribute of the power are not set to anything. This script will set both attributes.

Note that I am using attrBonus which should include level/2 as well as some other possible modifiers to pick which attribute to use. This might pick wrong if somehow the attack modifier is better for one attribute and the damage is better for a different attribute.

[cryptoknight]

It's close but I ran into 1 problem.

attridstring is an invalid identifier, I think variables are capped at 8 characters for their names.... I renamed them to attidstr and that goes away.

It's now telling me that eachpick doesn't exist.

I set the priority to 5000 index 1 After: Calc attrBonus

var bonus as number
var attidstr as string

~ Use Int as default - this might not be necessary
bonus = #attrbonus[attrInt]
attidstr = "attrInt"

~ Find highest bonus
foreach pick in hero from Attribute
  if (eachpick.field[attrBonus].value > bonus) then
    bonus = eachpick.field[attrBonus].value
    attidstr = eachpick.field[name].idstring
  endif
nexteach

~ Use that as the damage and attack attributes
perform assignstr["DamageAttr." & attidstr]
perform assignstr["Attack." & attidstr]

[Daphne Pfister]

Originally Posted by cryptoknight

It's close but I ran into 1 problem.

attridstring is an invalid identifier, I think variables are capped at 8 characters for their names.... I renamed them to attidstr and that goes away.

I found the problem try I should have used eachpick.idstring instead of eachpick.field[name].idstring.

Seemed to work when I tried it.

var bonus as number
var attidstr as string

~ Use Int as default - this might not be necessary
bonus = #attrbonus[attrInt]
attidstr = "attrInt"

~ Find highest bonus
foreach pick in hero from Attribute
  if (eachpick.field[attrBonus].value > bonus) then
    bonus = eachpick.field[attrBonus].value
    attidstr = eachpick.idstring
  endif
nexteach

~ Use that as the damage and attack attributes
perform assignstr["DamageAttr." & attidstr]
perform assignstr["Attack." & attidstr]

[MagicSN]

Originally Posted by Daphne Pfister

I found the problem try I should have used eachpick.idstring instead of eachpick.field[name].idstring.

Seemed to work when I tried it.

var bonus as number
var attidstr as string

~ Use Int as default - this might not be necessary
bonus = #attrbonus[attrInt]
attidstr = "attrInt"

~ Find highest bonus
foreach pick in hero from Attribute
  if (eachpick.field[attrBonus].value > bonus) then
    bonus = eachpick.field[attrBonus].value
    attidstr = eachpick.idstring
  endif
nexteach

~ Use that as the damage and attack attributes
perform assignstr["DamageAttr." & attidstr]
perform assignstr["Attack." & attidstr]

Hmmm, something is still wrong. It is now ALWAYS using the Default Attribute, no matter how high the other attributes are.

Maybe I did the part with the timing wrong? I wrote "Calc attrBonus" into the window which was labeled "After Scripts:" and nothing else there (and I entered the version of the script which I am citing in this email, and set the Phase to "Traits". And I set "Damage attribute" and "Attack Ability" to None.

MagicSN

[Daphne Pfister]

Originally Posted by MagicSN

Hmmm, something is still wrong. It is now ALWAYS using the Default Attribute, no matter how high the other attributes are.

Maybe I did the part with the timing wrong? I wrote "Calc attrBonus" into the window which was labeled "After Scripts:" and nothing else there (and I entered the version of the script which I am citing in this email, and set the Phase to "Traits". And I set "Damage attribute" and "Attack Ability" to None.

MagicSN

This is what is working for me.

[cryptoknight]

I was going to step in here and say. Did you set the Priority high enough?

The Priority number governs when in the Traits phase things happen. It needs to be high enough and set to run after a given script in order to work right.