View Single Post
Mathias
Senior Member
Lone Wolf Staff
 
Join Date: May 2005
Posts: 13,213

Old August 23rd, 2013, 08:38 AM
If you want to post examples, I recommend you fix a few coding style issues:

You should never use SpcReplace as your test for whether something is disabled. SpcReplace should never be present without SpcDisable also being present, because it's there only to describe why a thing was disabled, and there are many things that will disable without replacing.

Your WepProf and wClass tag handling should have comments - I can't figure out why you're forwarding those to the hero, or why you're pulling in two different tags, then only using one of them in the search.

For a search through weapons, don't you want to use IsWeapon - that's the tag that means "we count as this weapon"?

A single line of tagreplace[] can be used instead of two lines of delete[] and assign[].

I recommend making sure that the weapon is two-handed before assigning one-handed to it. Otherwise, you'll be assigning the one-handed tag to all the light weapons, too, and you'll be doubling up that tag on all the weapons that were already one-handed.

Last edited by Mathias; August 23rd, 2013 at 09:00 AM.
Mathias is offline   #4 Reply With Quote