View Single Post
dungeonguru
Senior Member
 
Join Date: May 2016
Posts: 608

Old September 12th, 2019, 06:37 AM
I'm hoping daplunk will jump in and correct/update me on the current standards but here is my $0.02.

1. What branch. The branch you should use is one you create for yourself. When you click the dropdown for branches you can create your branch off the master. It is recommended that you name your branch username-MMDDYYYY-ISSUE# so that people can see who created the branch, when they did it, and what issue # they were working on. Obviously not everyone seems to do that right now, seems they name it after the project they are working on.

For the big projects I'm not 100% sure if everyone should be uploading into the same repository. Regardless, you probably shouldn't touch the master branch until you merge your changes in when you are done on your branch.

2. Standards. The only standards I'm aware of are with the ID- ra5CXXXAbiNm where XXX was the abbreviation for the source (like COS for curse of strahd) and the AbiNm was a condensed version of the name. I've not seen a standard script recommendation guide for leaving abText for alternate name or abValue1 for scripted values but given the number of abilities that could be shared if they followed the scripting in an ability like Magic Resistance it might make sense to document that somewhere.

As far as the ID goes, past stuff was limited by the length of the ID being restricted to a very short length. Since an update sometime last year this length increased but I would stick with at least doing the ra5CXXX portion to show what source the material came from and not use the maximum length in case this changes again.

3. I think there is more info in the github "wiki" about merging your changes in. You do a pull request, review that there aren't any conflicts and commit to master if you're feeling brave or asking someone else to finish the merge if you don't know what you're doing. After the merge completes or is completed, you can delete your branch and start a new one for a new issue.

Hope some of that helps.
dungeonguru is offline   #2 Reply With Quote